Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Add macro for ros1/2 finding gtest and gmock #30

Merged
merged 5 commits into from
Jun 26, 2019

Conversation

ross-desmond
Copy link
Contributor

The macro find_common_test_packages will use ament or catkin to link to gtest and gmock libraries.

Note: You must add dependencies on gtest and gmock in the package.xml still

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ross-desmond ross-desmond force-pushed the test-dependency-macro branch 2 times, most recently from 50c37ac to 16f3ebe Compare May 8, 2019 20:01
@mm318 mm318 force-pushed the test-dependency-macro branch from 16f3ebe to d6025d3 Compare May 21, 2019 09:00
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files          16       16           
  Lines         820      820           
=======================================
  Hits          734      734           
  Misses         86       86
Flag Coverage Δ
#ROS_1 89.51% <ø> (ø) ⬆️
#ROS_2 ?
#bouncy ?
#crystal ?
#kinetic 89.61% <ø> (ø) ⬆️
#lunar 89.61% <ø> (ø) ⬆️
#melodic 91.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9a41a...d67abee. Read the comment docs.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files          16       16           
  Lines         820      820           
=======================================
  Hits          734      734           
  Misses         86       86
Flag Coverage Δ
#ROS_1 89.51% <ø> (ø) ⬆️
#ROS_2 ?
#bouncy ?
#crystal ?
#kinetic 89.61% <ø> (ø) ⬆️
#lunar ?
#melodic 91.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d7189...4aee1ca. Read the comment docs.

@mm318 mm318 force-pushed the test-dependency-macro branch from d67abee to 1eb321d Compare May 23, 2019 06:18
@timrobotson
Copy link

When using the latest commit I'm getting errors about being unable to find gmock:

CMake Warning at /opt/ros/kinetic/share/catkin/cmake/test/gtest.cmake:149 (message):
  skipping gmock 'test_aws_log_system' in project 'aws_common' because gmock
  was not found
Call Stack (most recent call first):
  /opt/ros/kinetic/share/catkin/cmake/test/gtest.cmake:79 (_catkin_add_executable_with_google_test)
  /opt/ros/kinetic/share/catkin/cmake/test/gtest.cmake:54 (_catkin_add_google_test)
  cmake/DefineTestMacros.cmake:48 (catkin_add_gmock)
  CMakeLists.txt:67 (add_common_gtest)

Using commit f25d518ef4113e0e7e6ac50a3eb076f03d89c94b works for me.

ross-desmond and others added 3 commits June 24, 2019 15:10
The macro `find_common_test_packages` will use ament or catkin to link to gtest and gmock libraries.

**Note:** You must add dependencies on gtest and gmock in the package.xml still
Signed-off-by: Miaofei <miaofei@amazon.com>
…ames

Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318 mm318 force-pushed the test-dependency-macro branch from 1eb321d to 570bb5b Compare June 24, 2019 22:12
mm318 added 2 commits June 24, 2019 15:28
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
@ross-desmond ross-desmond merged commit 3f72785 into master Jun 26, 2019
@ross-desmond ross-desmond deleted the test-dependency-macro branch June 26, 2019 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants