Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-role/non-profile authentication #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gene1wood
Copy link

Description of changes:

This adds support for cases where you're using this tool either with an assumed role in a profile (which has a session token) or with environment variables (instead of a role or profile)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This adds support for cases where you're using this tool either with an assumed role in a profile (which has a session token) or with [environment variables](https://docs.aws.amazon.com/sdkref/latest/guide/environment-variables.html) (instead of a role or profile)
@gene1wood
Copy link
Author

Oh, this fixes the same bug as #10

Copy link

@sandeepkanabar sandeepkanabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepkanabar
Copy link

Just saw that a PR #10 similar to this was also created on Feb 16. But looks like it is still NOT merged. @horsfieldsa @hyandell @marcosortiz can you please merge either this PR or #10 although if #10 could check for existence of token before setting it, it would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants