Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add vpc to all lambdas, allow users to self manage install bucket assets #15

Conversation

sydefz
Copy link
Contributor

@sydefz sydefz commented Apr 8, 2024

Description of changes:

This PR

  • Adds vpc to all lambdas to enhance security (without it the lambda will run on lambda vpc which has access to public internet)
  • Adds a selfManageInstallationBucketAssets prop to allow self management on druid installation assets (scripts, extension and druid image etc)

The changes is tested on

  • A existing ec2 stack, the lambdas are updated to use the correct vpc, and bucketDeployment are correctly disabled by turning on selfManageInstallationBucketAssets

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sydefz sydefz force-pushed the sydefz/config-lambda-vpc-custom-bucket-deployment branch from b54c440 to ac558a1 Compare April 8, 2024 04:43
@sydefz sydefz force-pushed the sydefz/config-lambda-vpc-custom-bucket-deployment branch from ac558a1 to 6ec2fac Compare April 8, 2024 04:45
@chn217 chn217 merged commit 16f3174 into aws-solutions:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants