Skip to content

Commit

Permalink
Fixed rare race conditions with simulcast + server side network adapt…
Browse files Browse the repository at this point in the history
…ation on third attendee join. (#2906)

* Fixed rare race conditions with simulcast + server side network adaptation on third attendee join.

* Docs

* Fix comments
  • Loading branch information
hensmi-amazon authored Jun 20, 2024
1 parent c6254b8 commit 90baf99
Show file tree
Hide file tree
Showing 17 changed files with 2,615 additions and 2,431 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed rare race conditions with simulcast + server side network adaptation on third attendee join.

## [3.22.0] - 2024-03-15

### Added
Expand Down
2 changes: 1 addition & 1 deletion demos/browser/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4,554 changes: 2,287 additions & 2,267 deletions docs/assets/js/search.js

Large diffs are not rendered by default.

34 changes: 17 additions & 17 deletions docs/classes/defaultaudiovideocontroller.html
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ <h3>audio<wbr>Input<wbr>Did<wbr>Change</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/mediastreambrokerobserver.html">MediaStreamBrokerObserver</a>.<a href="../interfaces/mediastreambrokerobserver.html#audioinputdidchange">audioInputDidChange</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1683">src/audiovideocontroller/DefaultAudioVideoController.ts:1683</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1682">src/audiovideocontroller/DefaultAudioVideoController.ts:1682</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -484,7 +484,7 @@ <h3>demote<wbr>From<wbr>Primary<wbr>Meeting</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#demotefromprimarymeeting">demoteFromPrimaryMeeting</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1656">src/audiovideocontroller/DefaultAudioVideoController.ts:1656</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1655">src/audiovideocontroller/DefaultAudioVideoController.ts:1655</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -534,7 +534,7 @@ <h3>encoding<wbr>Simulcast<wbr>Layers<wbr>Did<wbr>Change</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/simulcastuplinkobserver.html">SimulcastUplinkObserver</a>.<a href="../interfaces/simulcastuplinkobserver.html#encodingsimulcastlayersdidchange">encodingSimulcastLayersDidChange</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1622">src/audiovideocontroller/DefaultAudioVideoController.ts:1622</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1621">src/audiovideocontroller/DefaultAudioVideoController.ts:1621</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -643,7 +643,7 @@ <h3>get<wbr>Remote<wbr>Video<wbr>Sources</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#getremotevideosources">getRemoteVideoSources</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1612">src/audiovideocontroller/DefaultAudioVideoController.ts:1612</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1611">src/audiovideocontroller/DefaultAudioVideoController.ts:1611</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand All @@ -665,7 +665,7 @@ <h3>handle<wbr>Has<wbr>Bandwidth<wbr>Priority</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1563">src/audiovideocontroller/DefaultAudioVideoController.ts:1563</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1562">src/audiovideocontroller/DefaultAudioVideoController.ts:1562</a></li>
</ul>
</aside>
<h4 class="tsd-parameters-title">Parameters</h4>
Expand All @@ -689,7 +689,7 @@ <h3>handle<wbr>Meeting<wbr>Session<wbr>Status</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#handlemeetingsessionstatus">handleMeetingSessionStatus</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1492">src/audiovideocontroller/DefaultAudioVideoController.ts:1492</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1491">src/audiovideocontroller/DefaultAudioVideoController.ts:1491</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -721,7 +721,7 @@ <h3>pause<wbr>Receiving<wbr>Stream</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#pausereceivingstream">pauseReceivingStream</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1592">src/audiovideocontroller/DefaultAudioVideoController.ts:1592</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1591">src/audiovideocontroller/DefaultAudioVideoController.ts:1591</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -750,7 +750,7 @@ <h3>promote<wbr>ToPrimary<wbr>Meeting</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#promotetoprimarymeeting">promoteToPrimaryMeeting</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1631">src/audiovideocontroller/DefaultAudioVideoController.ts:1631</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1630">src/audiovideocontroller/DefaultAudioVideoController.ts:1630</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -806,7 +806,7 @@ <h3>reconnect</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#reconnect">reconnect</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1344">src/audiovideocontroller/DefaultAudioVideoController.ts:1344</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1343">src/audiovideocontroller/DefaultAudioVideoController.ts:1343</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -862,7 +862,7 @@ <h3>replace<wbr>Local<wbr>Audio</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#replacelocalaudio">replaceLocalAudio</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1222">src/audiovideocontroller/DefaultAudioVideoController.ts:1222</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1221">src/audiovideocontroller/DefaultAudioVideoController.ts:1221</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -892,7 +892,7 @@ <h3>replace<wbr>Local<wbr>Video</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#replacelocalvideo">replaceLocalVideo</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1187">src/audiovideocontroller/DefaultAudioVideoController.ts:1187</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1186">src/audiovideocontroller/DefaultAudioVideoController.ts:1186</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -923,7 +923,7 @@ <h3>restart<wbr>Local<wbr>Video</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#restartlocalvideo">restartLocalVideo</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1164">src/audiovideocontroller/DefaultAudioVideoController.ts:1164</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1163">src/audiovideocontroller/DefaultAudioVideoController.ts:1163</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -965,7 +965,7 @@ <h3>resume<wbr>Receiving<wbr>Stream</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#resumereceivingstream">resumeReceivingStream</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1598">src/audiovideocontroller/DefaultAudioVideoController.ts:1598</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1597">src/audiovideocontroller/DefaultAudioVideoController.ts:1597</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -1024,7 +1024,7 @@ <h3>set<wbr>Video<wbr>Codec<wbr>Send<wbr>Preferences</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#setvideocodecsendpreferences">setVideoCodecSendPreferences</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1604">src/audiovideocontroller/DefaultAudioVideoController.ts:1604</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1603">src/audiovideocontroller/DefaultAudioVideoController.ts:1603</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -1064,7 +1064,7 @@ <h3>set<wbr>Video<wbr>Max<wbr>Bandwidth<wbr>Kbps</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#setvideomaxbandwidthkbps">setVideoMaxBandwidthKbps</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1548">src/audiovideocontroller/DefaultAudioVideoController.ts:1548</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1547">src/audiovideocontroller/DefaultAudioVideoController.ts:1547</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -1232,7 +1232,7 @@ <h3>update<wbr>Local<wbr>Video<wbr>From<wbr>Policy</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1124">src/audiovideocontroller/DefaultAudioVideoController.ts:1124</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1123">src/audiovideocontroller/DefaultAudioVideoController.ts:1123</a></li>
</ul>
</aside>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
Expand All @@ -1250,7 +1250,7 @@ <h3>video<wbr>Input<wbr>Did<wbr>Change</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/mediastreambrokerobserver.html">MediaStreamBrokerObserver</a>.<a href="../interfaces/mediastreambrokerobserver.html#videoinputdidchange">videoInputDidChange</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1665">src/audiovideocontroller/DefaultAudioVideoController.ts:1665</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1664">src/audiovideocontroller/DefaultAudioVideoController.ts:1664</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down
Loading

0 comments on commit 90baf99

Please sign in to comment.