Migrate ec2 package to aws-sdk-to-v2 #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinnywang
force-pushed
the
aws-sdk-go-v2/ec2
branch
from
22ff5ef to
0a26173
Compare
tinnywang
force-pushed
the
aws-sdk-go-v2/ec2
branch
from
0a26173 to
2a6cfc8
Compare
tinnywang
force-pushed
the
aws-sdk-go-v2/ec2
branch
from
2a6cfc8 to
f5dfaec
Compare
tinnywang
force-pushed
the
aws-sdk-go-v2/ec2
branch
3 times, most recently
from
b985a4d to
c95cc58
Compare
|
Thanks a bunch for making this change! |
mye956
reviewed
Dec 4, 2024
tinnywang
force-pushed
the
aws-sdk-go-v2/ec2
branch
2 times, most recently
from
14ff880 to
58d51ed
Compare
mye956
approved these changes
Dec 6, 2024
prateekchaudhry
approved these changes
Dec 7, 2024
tinnywang
force-pushed
the
aws-sdk-go-v2/ec2
branch
from
58d51ed to
96a4355
Compare
BinSquare
pushed a commit
to BinSquare/amazon-ecs-agent
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the EC2 and EC2 metadata clients in the
ec2package toaws-sdk-go-v2.Implementation details
session.Sessiontoaws.Configper the docs.instancecreds.GetCredentialstoproviders.NewInstanceCredentialsCacheto use credentials providers compatible withaws-sdk-go-v2, per the docs.ec2metadata.EC2Metadatatoimds.Clientand update client construction per the docs.ec2.EC2toec2.Clientand update client construction per the docs.Testing
New tests cover the changes: no
Description for the changelog
Migrate ec2 package to aws-sdk-to-v2.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.