Skip to content

Commit

Permalink
Make RegisterTaskDefiniton method private because it is not used outs…
Browse files Browse the repository at this point in the history
…ide of package
  • Loading branch information
PettitWesley committed Feb 22, 2019
1 parent dac446f commit 8c3dc3d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions ecs-cli/modules/clients/aws/ecs/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ type ECSClient interface {
DeleteService(serviceName string) error

// Task Definition related
RegisterTaskDefinition(request *ecs.RegisterTaskDefinitionInput) (*ecs.TaskDefinition, error)
RegisterTaskDefinitionIfNeeded(request *ecs.RegisterTaskDefinitionInput, tdCache cache.Cache) (*ecs.TaskDefinition, error)
DescribeTaskDefinition(taskDefinitionName string) (*ecs.TaskDefinition, error)

Expand Down Expand Up @@ -177,7 +176,7 @@ func (c *ecsClient) DescribeService(serviceName string) (*ecs.DescribeServicesOu
return output, err
}

func (c *ecsClient) RegisterTaskDefinition(request *ecs.RegisterTaskDefinitionInput) (*ecs.TaskDefinition, error) {
func (c *ecsClient) registerTaskDefinition(request *ecs.RegisterTaskDefinitionInput) (*ecs.TaskDefinition, error) {
resp, err := c.client.RegisterTaskDefinition(request)
if err != nil {
log.WithFields(log.Fields{
Expand Down Expand Up @@ -260,7 +259,7 @@ func (c *ecsClient) constructTaskDefinitionCacheHash(taskDefinition *ecs.TaskDef

// persistTaskDefinition registers the task definition with ECS and creates a new local cache entry
func persistTaskDefinition(request *ecs.RegisterTaskDefinitionInput, client *ecsClient, taskDefinitionCache cache.Cache) (*ecs.TaskDefinition, error) {
resp, err := client.RegisterTaskDefinition(request)
resp, err := client.registerTaskDefinition(request)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 8c3dc3d

Please sign in to comment.