-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile for linux-arm64 #1066
Compile for linux-arm64 #1066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding support for arm64!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@otterley can you provide any output or details you have re: the kind of testing you did to verify the resulting binary works on the listed instance types?
arm64 integration test result:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional details, @otterley ! I understand we're waiting on some prerequisite changes before we can merge this in, so keeping this open until we're good there.
Hi! This is still a need, what are the plans for Arm64 support for the ecs-cli? |
Hi @scottmalkie, we've added a linux/Arm64 binary to our S3 buckets and updated the readme accordingly. These are built and tested on a Codebuild ARM image. Please let us know if you experience any difficulties using these binaries. |
Ah, perfect! Thanks so much @bvtujo ! I saw this as closed, didn't realize it was closed as done! I'll give it a spin and let you know what happens. |
Compile ecs-cli for Linux arm64, for compatibility for a1 and {m,c,r}6g instance types.
Fixes #1065
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.