Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capacity provider strategy support #1111

Open
wants to merge 4 commits into
base: mainline
Choose a base branch
from

Conversation

cixelsyd
Copy link

@cixelsyd cixelsyd commented Oct 9, 2020

Add capacity provider support via command line flags, in the same vein as the existing target-groups support.

Addresses #1089

Hi everyone, I have not made an open source contribution before, but we want to use capacity providers with our ecs-cli implementation, so I wrote it in. I have not added any tests: I have not written golang tests before.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • Unit tests passed
  • Integration tests passed
  • Unit tests added for new functionality
  • Listed manual checks and their outputs in the comments (example)
  • Link to issue or PR for the integration tests:

Documentation

  • Contacted our doc writer
  • Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Steven Craig and others added 4 commits October 7, 2020 22:46
…ting and parsing the flag. i do not think that it will actually take appropriate action on the flags though
@allisaurus
Copy link
Contributor

@cixelsyd it looks like there was a build failure in github.com/aws/amazon-ecs-cli/ecs-cli/modules/utils. If you're still interested in taking this PR forward can you take a look and update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants