Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Amazon Linux 2 #647

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Use Amazon Linux 2 #647

merged 1 commit into from
Oct 25, 2018

Conversation

PettitWesley
Copy link
Contributor

@PettitWesley PettitWesley commented Oct 23, 2018 •
edited
Loading

🎉

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@PettitWesley
Copy link
Contributor Author 

$ ecs-cli up --cluster AL2 --region sa-east-1 --capability-iam
WARN[0000] You will not be able to SSH into your EC2 instances without a key pair. 
INFO[0002] Using recommended Amazon Linux 2 AMI with ECS Agent 1.21.0 and Docker version 18.06.1-ce 
INFO[0003] Created cluster                               cluster=AL2 region=sa-east-1
INFO[0005] Waiting for your cluster resources to be created... 
INFO[0006] Cloudformation stack status                   stackStatus=CREATE_IN_PROGRESS
INFO[0068] Cloudformation stack status                   stackStatus=CREATE_IN_PROGRESS
INFO[0130] Cloudformation stack status                   stackStatus=CREATE_IN_PROGRESS
VPC created: vpc-0a12c3964611378eb
Security Group created: sg-0a8dac30b0638ec5b
Subnet created: subnet-062d45cfe9f66ce62
Subnet created: subnet-0ca68a63dd3f39f08
Cluster creation succeeded.

jahkeup
jahkeup reviewed Oct 23, 2018
View reviewed changes
ecs-cli/modules/clients/aws/ssm/client.go
@@ -55,7 +55,7 @@ func NewSSMClient(commandConfig *config.CommandConfig) Client {

func (c *ssmClient) GetRecommendedECSLinuxAMI() (*AMIMetadata, error) {
response, err := c.client.GetParameter(&ssm.GetParameterInput{
Name: aws.String(amazonLinuxRecommendedParameterName),
Name: aws.String(amazonLinux2RecommendedParameterName),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

Are there any other tangential changes (such as default user data scripts) that could be required with switching to AL2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahkeup not sure honestly, you tell me 😛

This is our default user data script template:

#!/bin/bash
echo ECS_CLUSTER=%s >> /etc/ecs/ecs.config

jahkeup
jahkeup approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚢 🎆 👍

@PettitWesley PettitWesley merged commit bbcc865 into aws:dev Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisaurus allisaurus allisaurus approved these changes

@jahkeup jahkeup jahkeup approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

@jhaynes jhaynes Awaiting requested review from jhaynes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PettitWesley @jahkeup @allisaurus