Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled race detector during the execution of unit tests #790

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Enabled race detector during the execution of unit tests #790

merged 1 commit into from
Jun 17, 2019

Conversation

hencrice
Copy link
Contributor

Description of changes:
Enabled the race detector when make test is executed.

And just for fun, I timed the make test command before and after this code change, there's essentially no difference:

Before:
real    1m14.350s
user    2m24.599s
sys     0m31.100s

After:
real    1m15.237s
user    2m29.455s
sys     0m31.182s

Testing

  • [Y] Unit tests passed
  • [N/A] Integration tests passed
  • [N/A] Unit tests added for new functionality
  • [N/A] Listed manual checks and their outputs in the comments (example)
  • [N/A] Link to issue or PR for the integration tests:

Documentation

  • [N/A] Contacted our doc writer
  • [N/A] Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@efekarakus efekarakus requested a review from a team June 14, 2019 23:19
efekarakus
efekarakus approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can you change the base branch to dev instead of ecs-local. We can just merge it there directly instead.

@hencrice hencrice changed the base branch from ecs-local to dev June 14, 2019 23:22
@hencrice hencrice changed the base branch from dev to ecs-local June 14, 2019 23:23
@hencrice hencrice changed the base branch from ecs-local to dev June 14, 2019 23:25
@hencrice hencrice changed the base branch from dev to ecs-local June 14, 2019 23:48
@hencrice hencrice requested a review from a team June 14, 2019 23:53
@hencrice hencrice merged commit 9f41f89 into aws:ecs-local Jun 17, 2019
@hencrice hencrice deleted the ecs-local branch June 17, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PettitWesley PettitWesley PettitWesley approved these changes

@efekarakus efekarakus efekarakus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hencrice @efekarakus @PettitWesley