Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up automatic pull for EC2 instance types #958

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Set up automatic pull for EC2 instance types #958

merged 2 commits into from
Dec 11, 2019

Conversation

iamhopaul123
Copy link
Contributor

@iamhopaul123 iamhopaul123 commented Dec 10, 2019 •
edited by SoManyHs
Loading

Fixes #954.

Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • Unit tests passed
  • Integration tests passed
  • Unit tests added for new functionality
  • Listed manual checks and their outputs in the comments (example)
  • Link to issue or PR for the integration tests:

Documentation

  • Contacted our doc writer
  • Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iamhopaul123 iamhopaul123 requested a review from a team December 10, 2019 21:08
SoManyHs
SoManyHs reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise LGTM! Can you add manual output?

ecs-cli/modules/clients/aws/cloudformation/cluster_template.go
"z1d.3xlarge",
"z1d.6xlarge",
"z1d.12xlarge"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

ecs-cli/modules/clients/aws/ec2/client.go Outdated Show resolved Hide resolved
@iamhopaul123
Copy link
Contributor Author

Manual test

$ecs-cli up --instance-type c5d.24xlarge

INFO[0000] Created cluster                               cluster=tutorial region=us-west-2
INFO[0001] Waiting for your cluster resources to be created... 
INFO[0001] Cloudformation stack status                   stackStatus=CREATE_IN_PROGRESS
INFO[0061] Cloudformation stack status                   stackStatus=CREATE_IN_PROGRESS
VPC created: vpc-0cd2ae4e0d0bb2fca
Subnet created: subnet-0387ca39986084594
Subnet created: subnet-074b81d5331f8be70
Cluster creation succeeded.

@iamhopaul123 iamhopaul123 merged commit 3d012a8 into aws:master Dec 11, 2019
@sonofachamp sonofachamp mentioned this pull request Apr 6, 2020
Closed
@SoManyHs SoManyHs mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoManyHs SoManyHs SoManyHs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c5d.24xlarge is not supported
2 participants
@iamhopaul123 @SoManyHs