This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
PKCS #11 MISRA / unit tests / Warnings Fix #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regressions caused by logging update regarding * MISRA violations. * Logging statements raising the GNU complexity of functions. * Warnings generated by improper integer types in log statements.
n9wxu
reviewed
Aug 21, 2020
| "but expected <= %lu.", xLabelLength, pkcs11configMAX_LABEL_LENGTH ) ); | ||
| xResult = CKR_DATA_LEN_RANGE; | ||
| } | ||
| else if( pdTRUE == xSemaphoreTake( xP11Context.xObjectList.xMutex, portMAX_DELAY ) ) |
There was a problem hiding this comment.
I am concerned about putting infinite delay's in a library without giving the user a choice in the matter.
It looks like this code will correctly handle the possibility of a timeout. Perhaps we should make the delay a long time in terms of PKCS11 behavior.
n9wxu
approved these changes
Aug 21, 2020
mingyue86010
approved these changes
Aug 21, 2020
ravibhagavandas
approved these changes
Aug 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes regressions caused by logging update regarding
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.