Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

PKCS #11 Remove iot prefix. #2563

Merged
merged 8 commits into from
Oct 16, 2020
Merged

PKCS #11 Remove iot prefix. #2563

merged 8 commits into from
Oct 16, 2020

Conversation

lundinc2
Copy link
Contributor

@lundinc2 lundinc2 commented Oct 13, 2020 •
edited
Loading

PKCS #11 Remove iot prefix.

Description

This change removes the iot prefix, and swaps it to the core prefix for PKCS files.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@karkhaz
Copy link
Contributor

karkhaz commented Oct 14, 2020

Hi! For some reason CI is failing to check out a submodule when we clone this code:

fatal: failed to unpack tree object 9e0a3c63943644bd1996884908d65dd117e75994
error: Submodule 'libraries/abstractions/pkcs11/corePKCS11' could not be updated.
error: Submodule 'libraries/abstractions/pkcs11/corePKCS11' cannot checkout new HEAD

this is when attempting to (recursively) check out 492401e that you pushed just now.

@lundinc2
Copy link
Contributor Author

Hey @karkhaz is this because the PKCS repo doesn't have the git modules update = none option set?

@lundinc2
Copy link
Contributor Author

/bot run checks

@lundinc2
Copy link
Contributor Author

/bot run checks

I've aligned it with the others, not sure why this one is failing.

sarenameas
sarenameas previously approved these changes Oct 15, 2020
View reviewed changes
sarenameas
sarenameas reviewed Oct 15, 2020
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
@lundinc2
Copy link
Contributor Author

@karkhaz FYI there are no cbmc proofs in the corePKCS11 repo, is the CI checking for some in there, and failing?

@lundinc2 lundinc2 requested a review from sarenameas October 16, 2020 20:32
@lundinc2 lundinc2 merged commit 808e040 into aws:master Oct 16, 2020
@aggarw13 aggarw13 mentioned this pull request Oct 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarenameas sarenameas sarenameas approved these changes

@n9wxu n9wxu n9wxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lundinc2 @karkhaz @n9wxu @sarenameas