Fixed aggregate issue and added unsupported exception for WHERE in JOIN #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyndonbauto
commented
Dec 16, 2021
sql-gremlin/src/main/java/org/twilmes/sql/gremlin/adapter/converter/SqlMetadata.java
Outdated
Show resolved
Hide resolved
lyndonbauto
commented
Dec 16, 2021
sql-gremlin/src/main/java/org/twilmes/sql/gremlin/adapter/converter/SqlTraversalEngine.java
Outdated
Show resolved
Hide resolved
xiazcy
approved these changes
Dec 16, 2021
sql-gremlin/src/main/java/org/twilmes/sql/gremlin/adapter/converter/SqlTraversalEngine.java
Outdated
Show resolved
Hide resolved
sql-gremlin/src/test/java/org/twilmes/sql/gremlin/adapter/GremlinSqlAdvancedSelectTest.java
Outdated
Show resolved
Hide resolved
alexey-temnikov
approved these changes
Dec 16, 2021
simonz-bq
reviewed
Dec 16, 2021
sql-gremlin/src/main/java/org/twilmes/sql/gremlin/adapter/converter/SqlTraversalEngine.java
Outdated
Show resolved
Hide resolved
sql-gremlin/src/main/java/org/twilmes/sql/gremlin/adapter/converter/SqlTraversalEngine.java
Show resolved
Hide resolved
Co-authored-by: Alexey Temnikov <alexeyt@bitquilltech.com> Co-authored-by: Yang Xia <55853655+xiazcy@users.noreply.github.com>
lyndonbauto
commented
Dec 16, 2021
sql-gremlin/src/main/java/org/twilmes/sql/gremlin/adapter/converter/SqlTraversalEngine.java
Outdated
Show resolved
Hide resolved
lyndonbauto
commented
Dec 16, 2021
...c/main/java/org/twilmes/sql/gremlin/adapter/converter/ast/nodes/select/GremlinSqlSelect.java
Outdated
Show resolved
Hide resolved
lyndonbauto
commented
Dec 16, 2021
...c/main/java/org/twilmes/sql/gremlin/adapter/converter/ast/nodes/select/GremlinSqlSelect.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Zhao <42222408+simonz-bq@users.noreply.github.com>
simonz-bq
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed aggregate issue and added unsupported exception for WHERE in JOIN
Description
Fixed aggregate issue and added unsupported exception for WHERE in JOIN
closes #126
Additional Reviewers
@birschick-bq
@lyndonb-bq
@xiazcy
@simonz-bq
@alexey-temnikov
@kylepbit