Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for publishing to Maven Central #208

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Refactor for publishing to Maven Central #208

merged 1 commit into from
Oct 19, 2022

Conversation

asarkar
Copy link
Contributor

@asarkar asarkar commented Oct 18, 2022

Summary

Refactor for publishing to Maven Central

Description

  1. Merge submodule sql-gremlin into root project.
  2. Clean up build.gradle following best practices.
  3. Configure publishing to aws.oss.sonatype.org.
  4. Upgrade Gradle version and Gradle plugin versions (not dependency versions).
  5. Configure build to not fail on checkstyle and SpotBugs violations (due to merging of the sql-gremlin submodule, there are new violations that aren't urgent to fix). Tracked in issue [BUG] Enable static code quality checks #209

@codecov-commenter
Copy link

Codecov Report

Merging #208 (3dca66b) into develop (9092f31) will increase coverage by 2.23%.
The diff coverage is 68.00%.

@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
+ Coverage    65.30%   67.53%   +2.23%     
===========================================
  Files           84      121      +37     
  Lines         4176     5874    +1698     
  Branches       312      585     +273     
===========================================
+ Hits          2727     3967    +1240     
- Misses        1239     1556     +317     
- Partials       210      351     +141     
Impacted Files Coverage Δ
...neptune/common/gremlindatamodel/MetadataCache.java 30.18% <ø> (ø)
...gremlindatamodel/SchemaHelperGremlinDataModel.java 0.00% <ø> (ø)
...remlindatamodel/resultset/ResultSetGetColumns.java 0.00% <ø> (ø)
...gremlindatamodel/resultset/ResultSetGetTables.java 0.00% <ø> (ø)
...eptune/gremlin/adapter/converter/SqlConverter.java 80.55% <ø> (ø)
...neptune/gremlin/adapter/converter/SqlMetadata.java 78.01% <ø> (ø)
.../gremlin/adapter/converter/SqlTraversalEngine.java 75.67% <ø> (ø)
...adapter/converter/ast/nodes/GremlinSqlFactory.java 77.41% <ø> (ø)
...erter/ast/nodes/operands/GremlinSqlIdentifier.java 63.63% <ø> (ø)
...erter/ast/nodes/operator/GremlinSqlAsOperator.java 41.02% <ø> (ø)
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@alexey-temnikov alexey-temnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asarkar asarkar merged commit 4b60574 into develop Oct 19, 2022
@asarkar asarkar deleted the mvn-publish branch October 19, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants