Fixed exception in DBVisualizer for LIMIT 1 queries. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyndonbauto
commented
Nov 25, 2021
simonz-bq
reviewed
Nov 26, 2021
sql-gremlin/src/test/java/org/twilmes/sql/gremlin/adapter/GremlinSqlBaseTest.java
Outdated
Show resolved
Hide resolved
simonz-bq
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed exception in DBVisualizer for LIMIT 1 queries.
Description
Limit 1 was giving intermittent exceptions in DBVisualizer. I investigated this for a while and found the root cause. Due to some timing with LIMIT 1, the interrupt (intended to unblock our BlockingQueue) was interrupting the ResultSet retrieval thread of DBVisualizer.
DBVisualizer was then reporting an error, even though all the results were properly retrieved.
To fix this I did changed the BlockingQueue unblock mechanism to use a specified extension of the List interface I made, which denotes that there are no more results. This removes the need for try/catch logic, synchronized blocks, over overall reduces complexity of pagination.
LIMIT 1 no longer errors in DBVisualizer, and I added some extra tests for it in our test class.
Related Issue
closes #69
Additional Reviewers
@birschick-bq
@lyndonb-bq
@xiazcy
@simonz-bq
@alexey-temnikov
@kylepbit