Incorrect GROUP BY and WHERE results #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…driver into lyndon/AN-911-incorrect-group-by-having-where-results
kylepbit
reviewed
Nov 26, 2021
...n/java/org/twilmes/sql/gremlin/adapter/converter/ast/nodes/select/GremlinSqlSelectMulti.java
Outdated
Show resolved
Hide resolved
.../java/org/twilmes/sql/gremlin/adapter/converter/ast/nodes/select/GremlinSqlSelectSingle.java
Show resolved
Hide resolved
simonz-bq
approved these changes
Nov 26, 2021
lyndonbauto
deleted the
lyndon/AN-911-incorrect-group-by-having-where-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Incorrect GROUP BY and WHERE results
Description
The issue is due to the way the data stream in the traversal gets modified if a group by is imposed before the where.
A detailed explanation of offending queries and result examples is provided in #75
To fix the issue, I switched the order of GROUP BY and WHERE such that WHERE is imposed before GROUP BY. This makes more sense since it will cause filtering to be imposed before grouping. Filtering does not change the data stream of the query but grouping does.
Related Issue
fixes #75
Additional Reviewers
@birschick-bq
@lyndonb-bq
@xiazcy
@simonz-bq
@alexey-temnikov
@kylepbit