Merge pull request #249 from mogren/fix-defer-close

Return the err from f.Close()
aws · Jan 8, 2019 · 9365868 · 9365868
2 parents c322c8d + ef47f01
commit 9365868
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/networkutils/network.go b/pkg/networkutils/network.go
@@ -381,12 +381,13 @@ func (n *linuxNetwork) setProcSys(key, value string) error {
 	if err != nil {
 		return err
 	}
-	defer f.Close()
 	_, err = f.WriteString(value)
 	if err != nil {
+		// If the write failed, just close
+		_ = f.Close()
 		return err
 	}
-	return nil
+	return f.Close()
 }
 
 type iptablesRule struct {