-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary for mtu and veth prefix check #1458
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipth
reviewed
May 7, 2021
abhipth
reviewed
May 7, 2021
abhipth
reviewed
May 7, 2021
abhipth
reviewed
May 7, 2021
Improved logic to test veth pairs
abhipth
reviewed
May 13, 2021
Migrated MTU and Veth check to host networking binary instead Updated env_vars_test file
abhipth
approved these changes
May 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jayanthvn
approved these changes
May 19, 2021
This was referenced Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Added binary support for validating mtu and veth prefix for aws-node daemonset
Which issue does this PR fix:
Ginkgo test won't have to run exec commands, instead they can invoke this binary to validate mtu and veth prefix
What does this PR do / Why do we need it:
To facilitate ginkgo testing
Testing done on this change:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.