Add more error messages during initialization #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nckturner
approved these changes
Sep 10, 2018
pkg/k8sapi/discovery.go
Outdated
| @@ -88,6 +88,8 @@ func CreateKubeClient(apiserver string, kubeconfig string) (clientset.Interface, | |||
| log.Infof("Testing communication with server") | |||
| v, err := kubeClient.Discovery().ServerVersion() | |||
| if err != nil { | |||
| log.Infof("Failed to communicate with K8S Server. Please check instance security groups or http proxy setting") | |||
| fmt.Printf("Failed to communicate with K8S Server. Please check instance security groups or http proxy setting") | |||
There was a problem hiding this comment.
Use fmt.Sprintf() to create the string and pass it to both.
liwenwu-amazon
force-pushed
the
log-flush
branch
from
11fd113
to
41fdef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #122 , if available:
Description of changes:
One of the common scenario that CNI ipamD fails to start is that it can not communicate with K8S master. Here are 2 possible root causes:
This PR adds more error msgs when this happens.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.