Improve setup advice in project README around ENI / IP address limits #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A link to vpc_ip_resource_limit.go was rendering simply as “see”; fix this. Signed-off-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: Tim Bannister <tim@scalefactory.com>
sftim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a (can make one if needed)
Description of changes: The current README on
mastermentions https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/awsutils/vpc_ip_resource_limit.go, and it looks like the link text is meant to show that filename. At the moment the link text renders as just “see”. This PR changes the rendered page to show the filename, and also rewords that paragraph for clarity.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.