-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send pod name/ns to nodeagent #2790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
Feb 12, 2024
achevuru
reviewed
Feb 14, 2024
jayanthvn
commented
Feb 14, 2024
jayanthvn
commented
Feb 14, 2024
achevuru
reviewed
Feb 14, 2024
achevuru
reviewed
Feb 14, 2024
achevuru
reviewed
Feb 14, 2024
jdn5126
reviewed
Feb 14, 2024
achevuru
approved these changes
Feb 14, 2024
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
In certain scenarios we would need to send pod name/ns to node agent
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Yes
Failed call to NA and kubelet will send delete so need to call cleanup... -
Successful call to NA -
Enabling strict mode even coredns will be blocked and egress from client pod will be blocked-
Upon enabling egress on client pod and ingress on coredns pods -
But client to server is blocked, since server hasn't allowed ingress -
Upon allowing client to server -
Even pod will be running -
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.