Integration test suite for Custom Networking + Security Groups for Pods #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
force-pushed
the
sgpp_and_cn
branch
3 times, most recently
from
b7ed952 to
cc88f6b
Compare
|
This PR has changes all in test suite and failed PR action is on vulns check. I will raise another PR to mitigate CVEs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
testing
Which issue does this PR fix?:
N/A
What does this PR do / Why do we need it?:
This PR adds a new integration test suite:
custom_networking_sgpp. This suite validates the combination of Custom Networking and Security Groups for Pods. The test cases are copied primarily from thepod_enitest suite. An additional test case is added to validate the Security Group assigned to the trunk ENI in this operating mode following #2792.There is one
TODOin this test suite, and that is to clone the cluster Security Group to the Security Group specified in theENIConfig. Currently, the Custom Networking Security Group just allows all traffic.Testing done on this change:
Verified that test suite passes.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.