Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add byobject filter on nodes #2888

Merged
merged 7 commits into from
Oct 23, 2024
+5 −1
Merged

Add byobject filter on nodes #2888

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c130709
Add byobject filter on nodes
GnatorX Apr 18, 2024
81c3e27
Merge branch 'master' into patch-1
jayanthvn Oct 11, 2024
1f2d6fc
format
garvinp-stripe Oct 11, 2024
c113c43
Merge branch 'master' into patch-1
GnatorX Oct 11, 2024
66e23e2
Merge branch 'master' into patch-1
GnatorX Oct 19, 2024
9ac7d0e
Merge branch 'master' into patch-1
GnatorX Oct 21, 2024
8fc2e8d
Merge branch 'master' into patch-1
jayanthvn Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/k8sapi/k8sutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ func getIPAMDCacheFilters() map[client.Object]cache.ByObject {
return map[client.Object]cache.ByObject{
&corev1.Pod{}: {
Field: fields.Set{"spec.nodeName": nodeName}.AsSelector(),
}}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous two related to changes to the cache improvements were these.

I am trying to understand why the only Pod{} to the filter here in the first place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it wasn't as obvious because this requires large clusters to show the increase in memory and networking bandwidth. We only saw this because our cluster is 4k node count

&corev1.Node{}: {
Field: fields.Set{"metadata.name": nodeName}.AsSelector(),
},
}
}
return nil
}
Expand Down
Loading