Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the SCRIPT_DIR reference in integration tests. #3090

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

orsenthil
Copy link
Member

@orsenthil orsenthil commented Oct 24, 2024

There was an inconsistent usage of SCRIPT_DIR reference in the scripts directory.
That's why with the previous bug, only integration tests were successful and rest of the tests in the pipeline were failing.

Made sure that Integration tests use the correct reference too.

Testing Done

 ./scripts/run-integration-tests.sh
Testing git repository at commit 6e7b18538f5c79b19feff1913fc69e3bebeaad6b
"xxx"
Logging in to docker repo
WARNING! Your password will be stored unencrypted in /home/ec2-user/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
Ensuring that amazon-k8s-cni exists for account xxx
creating ECR repo with name amazon-k8s-cni in registry account xxx
..
Ensuring that amazon-k8s-cni-init exists for account xxx
creating ECR repo with name amazon-k8s-cni-init in registry account xxx
...
Image amazon-k8s-cni:6e7b18538f5c79b19feff1913fc69e3bebeaad6b does not exist in repository.
docker buildx build --build-arg golang_image="public.ecr.aws/eks-distro-build-tooling/
...

@orsenthil orsenthil requested a review from a team as a code owner October 24, 2024 15:41
Copy link
Contributor

@jaydeokar jaydeokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orsenthil orsenthil merged commit 2977ae2 into master Oct 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants