Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up aws-cni-support.sh and update the documentation. #320

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Clean up aws-cni-support.sh and update the documentation. #320

merged 3 commits into from
Mar 6, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Feb 11, 2019

Cleanup

Issue #, if available:
Fixes #285 and #311

Description of changes:

  • Standardized on .out for output
  • Create log directory if it doesn't exist
  • Stop referencing localhost:10255
  • Consistent parameter substitution

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

samandmoore
samandmoore reviewed Feb 14, 2019
View reviewed changes
scripts/aws-cni-support.sh Outdated Show resolved Hide resolved
scripts/aws-cni-support.sh Outdated Show resolved Hide resolved
ankon
ankon reviewed Feb 18, 2019
View reviewed changes
scripts/aws-cni-support.sh Outdated Show resolved Hide resolved
ankon
ankon reviewed Feb 18, 2019
View reviewed changes
scripts/aws-cni-support.sh Outdated Show resolved Hide resolved
@mogren
Copy link
Contributor Author

mogren commented Feb 28, 2019

Updated PR after comments.

@mogren mogren force-pushed the support-script-fixes branch 2 times, most recently from 7420b1d to dae464e Compare February 28, 2019 23:47
@mogren mogren requested review from nckturner and removed request for mattlandis March 1, 2019 04:31
Clean up aws-cni-support.sh and update the documentation.
b022b27 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
@mogren mogren added this to the v1.4 milestone Mar 5, 2019
@mogren mogren merged commit 53b7071 into aws:master Mar 6, 2019
@mogren mogren deleted the support-script-fixes branch March 6, 2019 21:49
@mogren mogren mentioned this pull request Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithu0115 nithu0115 nithu0115 left review comments

@ankon ankon ankon left review comments

@nckturner nckturner nckturner left review comments

@samandmoore samandmoore samandmoore left review comments

@vsiddharth vsiddharth vsiddharth approved these changes

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@mogren @samandmoore @nckturner @ankon @vsiddharth @nithu0115