-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calico.yaml for 1.3 branch #368
Conversation
looking at it tonight, and running it through our CI. will post result when it's done. Thanks for picking it up @mogren |
@mogren manifest passed our CI w/3.3.6 images but after a manual diff of changes between v3.1.3 and v3.3.6, I want to suggest some more changes and run another test. |
@2ffs2nns Sure! I'm fine with that, thanks for testing. |
@mogren my git foo is failing me, there are multiple edits that need to be made to get this manifest in-sync with calico-v3.3.6 I've created a gist based off of your edits and posted here you can look at the edits I made
validation I completed w/above edits
all looked good/passing. If you make these changes, I'll run through our CI again if you like w/your final changes |
@@ -177,7 +198,10 @@ metadata: | |||
spec: | |||
scope: Cluster | |||
group: crd.projectcalico.org | |||
version: v1 | |||
versions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using version:
is deprecated, so I changed this according to the documentation https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#create-a-customresourcedefinition
I ran the 1.3 file in |
Description of changes:
Based on #232, but includes a version bump to v3.3.6 to get the
libcalico-go #1051 fix.
For details, see https://docs.projectcalico.org/v3.3/releases/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.