Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid trying tearing down NS #667

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Avoid trying tearing down NS #667

merged 1 commit into from
Oct 23, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Oct 21, 2019

Issue #641

Description of changes:
When deleting a deleted pod, we should not call TeardownNS

  • Added Trace logging of pod events
  • Check for IP before trying to tear down network namespace

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

When deleding a deleted pod, we should not call TeardownNS

Related to aws#641
@nithu0115
Copy link
Contributor

nithu0115 commented Oct 22, 2019

Thanks for the fix @mogren. I am custom built CNI running in my cluster that include this commit over night. So far, I do not see issues ( pod to pod connectivity or pod to coreDNS connectivity or pod to external service connectivity or missing rules as mentioned on #641 ) .

@mogren mogren mentioned this pull request Oct 23, 2019
@mogren mogren merged commit 8e1dc90 into aws:master Oct 23, 2019
@mogren mogren deleted the fix-ip-rule-issue branch October 23, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants