-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts/lib: use tester v0.8.5 #875
Conversation
@gyuho what do you mean by "worker nodes aren't used for now"? The MNG's worker nodes are indeed used to house Pods that are spun up in the integration tests... |
@jaypipes Meant to say worker nodes "logs" :) |
@gyuho worker nodes logs are useful while investigating failures. What's the harm in uploading these logs? Do we pay for these extra spaces somewhere? |
@SaranBalaji90 Currently, the tester tool only downloads to the local machine. Uploading config file and kubeconfig to S3 bucket is supported but upload all logging files aren't "yet". I can implement this feature in the next release. |
Updated upstream to upload gzipped file
Will release a new one. |
@jaypipes @SaranBalaji90 Released a new one Now uploads gzipped log files to S3 bucket. |
Nice! Running the tests now |
@gyuho what I meant to ask is, do we still upload kubelet logs? that's super useful for investigation. |
@SaranBalaji90 Yes. e.g. |
Uploads worker node logs to S3 bucket (gzipped) Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Worker nodes logs aren't used for now, so disable.https://github.com/aws/aws-k8s-tester/blob/master/CHANGELOG-0.8.md