Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the cluster URL as the default cluster ID #1131

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

aaron-congo
Copy link
Contributor

Summary

fix: use the cluster URL as the default cluster ID

Description

The RdsHostListProvider contains logic to use the cluster URL as a default cluster ID if the user passed a cluster URL, but there was a bug where this was not working correctly. The code was passing a string containing the host and port of the cluster URL, but the regex we use to identify whether a string is a cluster URL does not expect a port, so the logic was not correctly recognizing when cluster URLs were passed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaron-congo aaron-congo marked this pull request as ready for review September 27, 2024 22:38
Copy link

github-actions bot commented Sep 27, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@aaron-congo aaron-congo merged commit 249194d into main Oct 3, 2024
6 checks passed
@aaron-congo aaron-congo deleted the fix-cluster-id branch October 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants