Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove MaxPermSize JVM arg in gradle.properties #1132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaron-congo
Copy link
Contributor

@aaron-congo aaron-congo commented Sep 27, 2024

Summary

chore: remove MaxPermSize JVM arg in gradle.properties

Description

The MaxPermSize JVM arg was recently added to gradle.properties (along with some other args) with the intent of allowing more memory so that the html test reporter would not receive an OutOfMemory error. However, in Java 8, MaxPermSize was replaced with MaxMetaspaceSize, so gradle would occasionally fail with Unrecognized VM option 'MaxPermSize=128m'. Additionally, by default, there is no limit on the MaxMetaspaceSize, so adding the arg actually adds stricter limits to the memory.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants