Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CustomEndpointTest initialization #1163

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

aaron-congo
Copy link
Contributor

Description

Fixes two problems with the Custom Endpoint Plugin integration tests:

  • custom endpoints are not allowed with multi-az deployments, so this commit disables the tests for multi-az
  • every custom endpoint ID in a given region has to be unique, even between different clusters. Appending a unique string to the custom endpoint IDs should ensure each cluster created for our integration tests has uniquely named custom endpoints

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Oct 22, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@aaron-congo aaron-congo merged commit c26868d into main Oct 23, 2024
6 checks passed
@aaron-congo aaron-congo deleted the fix-custom-endpoint-test branch October 23, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants