fix: limitless plugin - reduce extraneous conns made in scenarios whe… #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchung-bitquill
force-pushed
the
fix/limitless-no-routers-conn
branch
2 times, most recently
from
aaede5b
to
34161bd
Compare
…re router cache is empty
aaronchung-bitquill
force-pushed
the
fix/limitless-no-routers-conn
branch
from
34161bd
to
c97edd6
Compare
sergiyvamz
reviewed
Oct 30, 2024
| } else { | ||
| LOGGER.finest(Messages.get("LimitlessConnectionPlugin.usingProvidedConnectUrl")); | ||
| return conn; | ||
| return connectFunc.call(); | ||
| } | ||
| } | ||
|
|
||
| if (limitlessRouters.contains(hostSpec)) { |
There was a problem hiding this comment.
Let's check for null here
sergiyvamz
reviewed
Oct 30, 2024
| conn = connectFunc.call(); | ||
| } | ||
| return retryConnectWithLeastLoadedRouters(limitlessRouters, props, conn, hostSpec); | ||
| return retryConnectWithLeastLoadedRouters(limitlessRouters, props, connectFunc.call(), connectFunc, hostSpec); | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
selectedHostSpec can be null
sergiyvamz
reviewed
Oct 30, 2024
| @@ -252,8 +242,8 @@ private Connection retryConnectWithLeastLoadedRouters( | |||
|
|
|||
| while (retryCount++ < maxRetries) { | |||
| if (currentRouters.stream().noneMatch(h -> h.getAvailability().equals(HostAvailability.AVAILABLE))) { | |||
| if (conn != null && !conn.isClosed()) { | |||
| currentRouters = synchronouslyGetLimitlessRoutersWithRetry(conn, hostSpec.getPort(), props); | |||
| if ((conn != null && !conn.isClosed())) { | |||
There was a problem hiding this comment.
What is conn is null but there's a connectFunc?
sergiyvamz
reviewed
Oct 30, 2024
| @@ -119,9 +121,10 @@ public List<HostSpec> forceGetLimitlessRoutersWithConn( | |||
| if (!Utils.isNullOrEmpty(limitlessRouters)) { | |||
| return limitlessRouters; | |||
| } | |||
| final List<HostSpec> newLimitlessRouters = connection == null || connection.isClosed() | |||
| ? this.queryHelper.queryForLimitlessRouters(connectFunc.call(), hostPort) | |||
There was a problem hiding this comment.
You open a connection and leave it hanging. Can we return this connection back to the plugin and further to a user app?
|
starting again on a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re router cache is empty
Summary
Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.