fix: limitless - reduce extraneous conns made on first connection + s… #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchung-bitquill
force-pushed
the
fix/limitless-extra-connns
branch
5 times, most recently
from
82c6522
to
ae5ff77
Compare
sergiyvamz
reviewed
Nov 4, 2024
| } | ||
|
|
||
| try { | ||
| if (selectedHostSpec == null) { |
There was a problem hiding this comment.
This code should be out of try-final. At line 148?
sergiyvamz
reviewed
Nov 4, 2024
| final int maxRetries = LimitlessConnectionPlugin.MAX_RETRIES.getInteger(context.getProps()); | ||
|
|
||
| while (retryCount++ < maxRetries) { | ||
| if (context.getLimitlessRouters() |
There was a problem hiding this comment.
We need a null check for getLimitlessRouters()
sergiyvamz
reviewed
Nov 4, 2024
| } | ||
| } | ||
|
|
||
| HostSpec selectedHostSpec = context.getHostSpec(); |
There was a problem hiding this comment.
HostSpec selectedHostSpec = null
?
sergiyvamz
reviewed
Nov 4, 2024
| } | ||
| Thread.sleep(retryIntervalMs); | ||
| } catch (final InterruptedException e) { | ||
| Thread.currentThread().interrupt(); |
There was a problem hiding this comment.
Thread.currentThread().interrupt();
return;
?
sergiyvamz
reviewed
Nov 4, 2024
|
|
||
| context.setLimitlessRouters(newLimitlessRouters); |
There was a problem hiding this comment.
if (!Utils.isNullOrEmpty(newLimitlessRouters)) {
...
}
There was a problem hiding this comment.
Added a line to throw an exception in case the it is either null or empty.
Reason for this is so that #synchronouslyGetLimitlessRoutersWithRetry can catch it and retry.
Otherwise if context.limitlessRouters is not null or empty for some reason, it will not retry.
sergiyvamz
reviewed
Nov 4, 2024
wrapper/src/main/java/software/amazon/jdbc/plugin/limitless/LimitlessRouterServiceImpl.java
Outdated
Show resolved
Hide resolved
aaronchung-bitquill
force-pushed
the
fix/limitless-extra-connns
branch
from
ae5ff77
to
be2b02a
Compare
sergiyvamz
approved these changes
Nov 4, 2024
aaronchung-bitquill
force-pushed
the
fix/limitless-extra-connns
branch
2 times, most recently
from
578ba0a
to
dc42231
Compare
…hift connection logic from plugin to service class
aaronchung-bitquill
force-pushed
the
fix/limitless-extra-connns
branch
from
dc42231
to
11cb0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hift connection logic from plugin to service class
Summary
Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.