Adding health check and liveness probe for controller #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishorj
reviewed
Dec 22, 2020
main.go
Outdated
| Port: 9443, | ||
| LeaderElection: enableLeaderElection, | ||
| LeaderElectionID: "appmesh-controller-leader-election", | ||
| HealthProbeBindAddress: ":61779", // the liveness endpoint is default to "/healthz" |
There was a problem hiding this comment.
Lets make this port configurable, via command line flag. We can use 61779 as the default.
There was a problem hiding this comment.
Sounds good. Updated the probe in config.
Test
$ curl http://192.168.85.101:61000/healthz
ok
kishorj
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#407
Description of changes:
Added health check and liveness probe for controller.
Test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.