Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mTLS based tests to the VirtualNode integration test suite #431

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

achevuru
Copy link
Contributor

Issue #, if available:
NA
Description of changes:

  • Add mTLS based tests to the VirtualNode integration test suite.
  • PR also addresses an intermittent issue with VirtualNode - CloudMap Test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@achevuru achevuru requested a review from fawadkhaliq January 28, 2021 07:59
@fawadkhaliq fawadkhaliq changed the title Enhance VirtualNode Integration test suite Add mTLS based tests to the VirtualNode integration test suite Jan 28, 2021
Copy link

@fawadkhaliq fawadkhaliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloud map virtual node test is still failing

Virtual Node scenarios
  /home/ssm-user/actions-runner/_work/aws-app-mesh-controller-for-k8s/aws-app-mesh-controller-for-k8s/test/integration/virtualnode/virtualnode_test.go:62
    should create a virtual node with CloudMap ServiceDiscovery enabled [It]
    /home/ssm-user/actions-runner/_work/aws-app-mesh-controller-for-k8s/aws-app-mesh-controller-for-k8s/test/integration/virtualnode/virtualnode_test.go:163

    Unexpected error:
        <*errors.errorString | 0xc000c043e0>: {
            s: "instance count mismatch",
        }
        instance count mismatch
    occurred

@achevuru
Copy link
Contributor Author

The cloud map virtual node test is still failing

Virtual Node scenarios
  /home/ssm-user/actions-runner/_work/aws-app-mesh-controller-for-k8s/aws-app-mesh-controller-for-k8s/test/integration/virtualnode/virtualnode_test.go:62
    should create a virtual node with CloudMap ServiceDiscovery enabled [It]
    /home/ssm-user/actions-runner/_work/aws-app-mesh-controller-for-k8s/aws-app-mesh-controller-for-k8s/test/integration/virtualnode/virtualnode_test.go:163

    Unexpected error:
        <*errors.errorString | 0xc000c043e0>: {
            s: "instance count mismatch",
        }
        instance count mismatch
    occurred

It is due to Envoy pointing to Prod while the appmesh resources are created in Preview. Issue will resolve itself once we point the controller away from preview.

@fawadkhaliq
Copy link

The cloud map virtual node test is still failing

Virtual Node scenarios
  /home/ssm-user/actions-runner/_work/aws-app-mesh-controller-for-k8s/aws-app-mesh-controller-for-k8s/test/integration/virtualnode/virtualnode_test.go:62
    should create a virtual node with CloudMap ServiceDiscovery enabled [It]
    /home/ssm-user/actions-runner/_work/aws-app-mesh-controller-for-k8s/aws-app-mesh-controller-for-k8s/test/integration/virtualnode/virtualnode_test.go:163

    Unexpected error:
        <*errors.errorString | 0xc000c043e0>: {
            s: "instance count mismatch",
        }
        instance count mismatch
    occurred

It is due to Envoy pointing to Prod while the appmesh resources are created in Preview. Issue will resolve itself once we point the controller away from preview.

Preview set here: #432 so we should be good once that is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants