Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to sync helm charts to eks-charts #435

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Add workflow to sync helm charts to eks-charts #435

merged 2 commits into from
Feb 2, 2021

Conversation

fawadkhaliq
Copy link

Issue
#412

Description of changes
Added a workflow to sync appmesh-controller Helm chart with eks-charts repo.

  • Added a script to sync charts if there's a diff. This uses eks-bot to open a pull request on eks-charts repo that will need to be reviewed, approved and merged by the authors. In long term, we plan to deprecate the eks-charts repo and host the charts elsewhere (where? to be designed/decided)
  • Added make target to sync on-demand and on release (includes release notes)
  • Added GitHub Actions workflow to sync appmesh-controller Helm to eks-chart repo on k8s controller release.

Future work
Since we'll need the same mechanism for other repos (VPC CNI, AWS load balancer controller etc), we will convert the sync script into a GitHub Action that lives by itself and can be shared/imported as a GitHub Action directly in the workflow, removing any code duplication

Testing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants