Allow for configuration of GORPOXY in docker build #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeb
approved these changes
Nov 16, 2022
rakeb
reviewed
Nov 16, 2022
| @@ -88,7 +88,7 @@ generate: controller-gen | |||
| # Requires buildx to be installed: https://docs.docker.com/buildx/working-with-buildx/ | |||
| # By default the TARGETPLATFORM is set to linux/amd64, change the value if you are building for linux/arm64 | |||
| docker-build: check-env test | |||
| docker buildx build --platform linux/amd64 -t $(IMAGE) . --load | |||
| docker buildx build --platform linux/amd64 --build-arg GOPROXY=$(GOPROXY) -t $(IMAGE) . --load | |||
There was a problem hiding this comment.
Are we only considering linux/amd64?
There was a problem hiding this comment.
The github workflow performs its own builds, including an arm64 image. Perhaps we could be a bit more clever about sharing the build setup and configuration for each, but as this is an existing setup that's not being changed by this patch I'm ok leaving that for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Let's the user customize the docker build GOPROXY variable when building the controller container image.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.