Adding Envoy variable in order to use FIPS endpoint #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardXF
reviewed
Nov 17, 2022
|
|
||
| func (m *envoyMutator) getUseFipsEndpoint(useFipsEndpoint bool) string { | ||
| if useFipsEndpoint { | ||
| return "1" |
There was a problem hiding this comment.
why we pass String instead of bool here?
There was a problem hiding this comment.
Actually Controller takes boolean and it converts into String because Envoy accepts FIPS endpoint as ENV variable which is String. so we are converting and passing it to envoy. If I am not wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added Envoy variable which enables the feature to use FIPS Endpoint
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.