Skip to content

Commit

Permalink
chore: only run release-notes if BUMP_CANDIDATE is false (#16956)
Browse files Browse the repository at this point in the history
The release-notes script generates a RELEASE_NOTES file based on the current
version and current changelog. During a BUMP_CANDIDATE build, a new version
number has been generated, but no corresponding changelog has been
created/updated. This causes the release notes to fail (and currently breaks the
pipeline).

Simplest fix is to skip release notes generation for these builds.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
njlynch committed Oct 13, 2021
1 parent 2d020be commit 263d0e7
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ if [ "$check_compat" == "true" ]; then
fi

# Create the release notes for the current version. These are ephemeral and not saved in source.
node ./scripts/create-release-notes.js
# Skip this step for a "bump candidate" build, where a new, fake version number has been created
# without any corresponding changelog entries.
if ! ${BUMP_CANDIDATE:-false}; then
node ./scripts/create-release-notes.js
fi

touch $BUILD_INDICATOR

0 comments on commit 263d0e7

Please sign in to comment.