Added testing

aws · Apr 25, 2024 · 291c665 · 291c665
1 parent 89cc140
commit 291c665
Show file tree

Hide file tree

Showing 11 changed files with 33 additions and 19 deletions.
diff --git a/.../aws-cdk-nlb-attributes-integ.assets.json → .../aws-cdk-nlb-attributes-integ.assets.json b/.../aws-cdk-nlb-attributes-integ.assets.json → .../aws-cdk-nlb-attributes-integ.assets.json
diff --git a/...ws-cdk-nlb-attributes-integ.template.json → ...ws-cdk-nlb-attributes-integ.template.json b/...ws-cdk-nlb-attributes-integ.template.json → ...ws-cdk-nlb-attributes-integ.template.json
@@ -403,10 +403,6 @@
       "Key": "load_balancing.cross_zone.enabled",
       "Value": "true"
      },
-     {
-      "Key": "ipv6.deny_all_igw_traffic",
-      "Value": "true"
-     },
      {
       "Key": "dns_record.client_routing_policy",
       "Value": "partial_availability_zone_affinity"

diff --git a/.../integ.nlb-attributes.js.snapshot/cdk.out → .../integ.nlb.attributes.js.snapshot/cdk.out b/.../integ.nlb-attributes.js.snapshot/cdk.out → .../integ.nlb.attributes.js.snapshot/cdk.out
diff --git a/...teg.nlb-attributes.js.snapshot/integ.json → ...teg.nlb.attributes.js.snapshot/integ.json b/...teg.nlb-attributes.js.snapshot/integ.json → ...teg.nlb.attributes.js.snapshot/integ.json
diff --git a/....nlb-attributes.js.snapshot/manifest.json → ....nlb.attributes.js.snapshot/manifest.json b/....nlb-attributes.js.snapshot/manifest.json → ....nlb.attributes.js.snapshot/manifest.json
diff --git a/...faultTestDeployAssert2D727654.assets.json → ...faultTestDeployAssert2D727654.assets.json b/...faultTestDeployAssert2D727654.assets.json → ...faultTestDeployAssert2D727654.assets.json
diff --git a/...ultTestDeployAssert2D727654.template.json → ...ultTestDeployAssert2D727654.template.json b/...ultTestDeployAssert2D727654.template.json → ...ultTestDeployAssert2D727654.template.json
diff --git a/...nteg.nlb-attributes.js.snapshot/tree.json → ...nteg.nlb.attributes.js.snapshot/tree.json b/...nteg.nlb-attributes.js.snapshot/tree.json → ...nteg.nlb.attributes.js.snapshot/tree.json
diff --git a/...dbalancingv2/test/integ.nlb-attributes.ts → ...dbalancingv2/test/integ.nlb.attributes.ts b/...dbalancingv2/test/integ.nlb-attributes.ts → ...dbalancingv2/test/integ.nlb.attributes.ts
diff --git a/packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/alb/load-balancer.test.ts b/packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/alb/load-balancer.test.ts
@@ -99,10 +99,6 @@ describe('tests', () => {
           Key: 'deletion_protection.enabled',
           Value: 'true',
         },
-        {
-          Key: 'ipv6.deny_all_igw_traffic',
-          Value: 'true',
-        },
         {
           Key: 'routing.http2.enabled',
           Value: 'false',
@@ -171,6 +167,21 @@ describe('tests', () => {
     }).toThrow('\'clientKeepAlive\' must be between 60 and 604800 seconds. Got: 100 milliseconds');
   });
 
+  test('throw error for denyAllIgwTraffic set to false for Ipv4 adressing.', () => {
+    // GIVEN
+    const stack = new cdk.Stack();
+    const vpc = new ec2.Vpc(stack, 'Stack');
+
+    // THEN
+    expect(() => {
+      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
+        vpc,
+        denyAllIgwTraffic: false,
+        ipAddressType: elbv2.IpAddressType.IPV4,
+      });
+    }).toThrow('\'denyAllIgwTraffic\' cannot be false on load balancers with IPv4 addressing.');
+  });
+
   describe('Desync mitigation mode', () => {
     test('Defensive', () => {
       // GIVEN

diff --git a/packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/nlb/load-balancer.test.ts b/packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/nlb/load-balancer.test.ts
@@ -91,10 +91,6 @@ describe('tests', () => {
           Key: 'load_balancing.cross_zone.enabled',
           Value: 'true',
         },
-        {
-          Key: 'ipv6.deny_all_igw_traffic',
-          Value: 'true',
-        },
         {
           Key: 'dns_record.client_routing_policy',
           Value: 'partial_availability_zone_affinity',
@@ -488,6 +484,21 @@ describe('tests', () => {
     }).toThrow('Load balancer name: "my load balancer" must contain only alphanumeric characters or hyphens.');
   });
 
+  test('loadBalancerName unallowed: denyAllIgwTraffic set to false for Ipv4 adressing', () => {
+    // GIVEN
+    const stack = new cdk.Stack();
+    const vpc = new ec2.Vpc(stack, 'Stack');
+
+    // THEN
+    expect(() => {
+      new elbv2.NetworkLoadBalancer(stack, 'NLB', {
+        vpc,
+        denyAllIgwTraffic: false,
+        ipAddressType: elbv2.IpAddressType.IPV4,
+      });
+    }).toThrow('\'denyAllIgwTraffic\' cannot be false on load balancers with IPv4 addressing.');
+  });
+
   test('imported network load balancer with no vpc specified throws error when calling addTargets', () => {
     // GIVEN
     const stack = new cdk.Stack();