Skip to content

Commit

Permalink
Merge branch 'aws:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
siddharthsalot authored Jan 26, 2022
2 parents b6f68c7 + 94b0ade commit 7f5bfdc
Show file tree
Hide file tree
Showing 12 changed files with 36 additions and 14 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/issue-label-assign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
types: [opened, edited]

jobs:
test:
triage-manager:
permissions:
issues: write
pull-requests: write
Expand All @@ -19,14 +19,19 @@ jobs:
github-token: "${{ secrets.GITHUB_TOKEN }}"
excluded-expressions: "[CDK CLI Version|TypeScript|Java|Python]"
area-is-keyword: true
excluded-labels: "[p1|p2|p0|contribution/core]"
default-area: >
{
"assignees":["NGL321","peterwoodworth","ryparker"]
}
parameters: >
[
{"area":"package/tools","keywords":["cli","command line","init","synth","diff","bootstrap"],"labels":["package/tools"],"assignees":["rix0rrr"]},
{"area":"@aws-cdk/alexa-ask","keywords":["alexa-ask","alexa", "cfnskill"],"labels":["@aws-cdk/alexa-ask"],"assignees":["madeline-k"]},
{"area":"@aws-cdk/app-delivery","keywords":["app-delivery","PipelineDeployStackAction"],"labels":["@aws-cdk/app-delivery"],"assignees":["skinny85"]},
{"area":"@aws-cdk/assert","keywords":["assert"],"labels":["@aws-cdk/assert"],"assignees":["kaizen3031593"]},
{"area":"@aws-cdk/assertions","keywords":["assertions"],"labels":["@aws-cdk/assertions"],"assignees":["kaizen3031593"]},
{"area":"@aws-cdk/assets","keywords":["assets","staging"],"labels":["@aws-cdk/assets"],"assignees":["eladb"]},
{"area":"@aws-cdk/assets","keywords":["assets","staging"],"labels":["@aws-cdk/assets"],"assignees":["otaviomacedo"]},
{"area":"@aws-cdk/aws-accessanalyzer","keywords":["aws-accessanalyzer","accessanalyzer","cfnanalyzer"],"labels":["@aws-cdk/aws-accessanalyzer"],"assignees":["skinny85"]},
{"area":"@aws-cdk/aws-acmpca","keywords":["aws-acmpca","acmpca","certificateauthority"],"labels":["@aws-cdk/aws-acmpca"],"assignees":["skinny85"]},
{"area":"@aws-cdk/aws-amazonmq","keywords":["aws-amazonmq","amazonmq","cfnbroker"],"labels":["@aws-cdk/aws-amazonmq"],"assignees":["otaviomacedo"]},
Expand Down Expand Up @@ -92,7 +97,7 @@ jobs:
{"area":"@aws-cdk/aws-dynamodb-global","keywords":["aws-dynamodb-global","dynamodb global"],"labels":["@aws-cdk/aws-dynamodb-global"],"assignees":["skinny85"]},
{"area":"@aws-cdk/aws-ec2","keywords":["aws-ec2","ec2","vpc","privatesubnet","publicsubnet","vpngateway","vpnconnection","networkacl"],"labels":["@aws-cdk/aws-ec2"],"assignees":["njlynch"]},
{"area":"@aws-cdk/aws-ecr","keywords":["aws-ecr","ecr"],"labels":["@aws-cdk/aws-ecr"],"assignees":["madeline-k"]},
{"area":"@aws-cdk/aws-ecr-assets","keywords":["aws-ecr-assets","ecrassets"],"labels":["@aws-cdk/aws-ecr-assets"],"assignees":["eladb"]},
{"area":"@aws-cdk/aws-ecr-assets","keywords":["aws-ecr-assets","ecrassets"],"labels":["@aws-cdk/aws-ecr-assets"],"assignees":["madeline-k"]},
{"area":"@aws-cdk/aws-ecs","keywords":["(aws-ecs)","(ecs)"],"labels":["@aws-cdk/aws-ecs"],"assignees":["madeline-k"]},
{"area":"@aws-cdk/aws-ecs-patterns","keywords":["(aws-ecs-patterns)","(ecs-patterns)"],"labels":["@aws-cdk/aws-ecs-patterns"],"assignees":["madeline-k"]},
{"area":"@aws-cdk/aws-efs","keywords":["aws-efs","efs","accesspoint"],"labels":["@aws-cdk/aws-efs"],"assignees":["corymhall"]},
Expand Down Expand Up @@ -224,7 +229,7 @@ jobs:
{"area":"@aws-cdk/custom-resources","keywords":["custom-resource","provider"],"labels":["@aws-cdk/custom-resources"],"assignees":["rix0rrr"]},
{"area":"@aws-cdk/cx-api","keywords":["cx-api","cloudartifact","cloudassembly"],"labels":["@aws-cdk/cx-api"],"assignees":["rix0rrr"]},
{"area":"@aws-cdk/aws-lambda-layer-awscli","keywords":["(aws-lambda-layer-awscli)","(lambda-layer-awscli)"],"labels":["@aws-cdk/aws-lambda-layer-awscli"],"assignees":["rix0rrr"]},
{"area":"@aws-cdk/aws-lambda-layer-kubectl","keywords":["(aws-lambda-layer-kubectl)","(lambda-layer-kubectl)"],"labels":["@aws-cdk/aws-lambda-layer-kubectl"],"assignees":["eladb"]},
{"area":"@aws-cdk/aws-lambda-layer-kubectl","keywords":["(aws-lambda-layer-kubectl)","(lambda-layer-kubectl)"],"labels":["@aws-cdk/aws-lambda-layer-kubectl"],"assignees":["otaviomacedo"]},
{"area":"@aws-cdk/pipelines","keywords":["pipelines","cdk-pipelines","sourceaction","synthaction"],"labels":["@aws-cdk/pipelines"],"assignees":["rix0rrr"]},
{"area":"@aws-cdk/region-info","keywords":["region-info","fact"],"labels":["@aws-cdk/region-info"],"assignees":["skinny85"]},
{"area":"aws-cdk-lib","keywords":["aws-cdk-lib","cdk-v2","v2","ubergen"],"labels":["aws-cdk-lib"],"assignees":["njlynch"]},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,17 @@ export class NotificationsResourceHandler extends Construct {
return properties;
}
}

const handlerSource = fs.readFileSync(path.join(__dirname, 'lambda/index.py'), 'utf8');
if (handlerSource.length > 4096) {
throw new Error(`Source of Notifications Resource Handler is too large (${handlerSource.length} > 4096)`);
}

const resource = new InLineLambda(this, 'Resource', {
type: resourceType,
properties: {
Description: 'AWS CloudFormation handler for "Custom::S3BucketNotifications" resources (@aws-cdk/aws-s3)',
Code: { ZipFile: fs.readFileSync(path.join(__dirname, 'lambda/index.py'), 'utf8') },
Code: { ZipFile: handlerSource },
Handler: 'index.handler',
Role: this.role.roleArn,
Runtime: 'python3.7',
Expand Down
5 changes: 5 additions & 0 deletions packages/@aws-cdk/cfnspec/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@

## Unapplied changes

* AWS::ECS is at 51.0.0

# CloudFormation Resource Specification v53.1.0

## New Resource Types
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@
"Required": false,
"UpdateType": "Mutable"
},
"RoutingControlArn": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-route53-healthcheck-healthcheckconfig.html#cfn-route53-healthcheck-healthcheckconfig-routingcontrolarn",
"PrimitiveType": "String",
"Required": false,
"UpdateType": "Mutable"
},
"SearchString": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-route53-healthcheck-healthcheckconfig.html#cfn-route53-healthcheck-healthcheckconfig-searchstring",
"PrimitiveType": "String",
Expand Down Expand Up @@ -154,4 +160,4 @@
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.csproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.csproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.fsproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.fsproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.csproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.csproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.fsproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.fsproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.csproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.csproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.fsproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.fsproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.csproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.csproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"app": "dotnet run -p src/%name.PascalCased%/%name.PascalCased%.fsproj",
"app": "dotnet run --project src/%name.PascalCased%/%name.PascalCased%.fsproj",
"watch": {
"include": ["**"],
"exclude": [
Expand Down

0 comments on commit 7f5bfdc

Please sign in to comment.