Skip to content

Commit

Permalink
fix(scheduler): typo in metricSentToDLQ... methods (#28307)
Browse files Browse the repository at this point in the history
This PR includes breaking changes to the `aws-scheduler-alpha` module.

## Description
This PR introduces breaking changes by correcting typos in the method names of the Schedule and Group constructs. 
Specifically, the method name `metricSentToDLQTrunacted` has been changed to `metricSentToDLQTruncated`, and `metricAllSentToDLQTrunacted` has been changed to `metricAllSentToDLQTruncated`.
https://docs.aws.amazon.com/scheduler/latest/UserGuide/monitoring-cloudwatch.html

BREAKING CHANGE: The typos in the Schedule and Group construct method names have been fixed, changing `metricSentToDLQTrunacted` to `metricSentToDLQTruncated` and `metricAllSentToDLQTrunacted` to `metricAllSentToDLQTruncated`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
sakurai-ryo authored Dec 8, 2023
1 parent fe30921 commit 8b91e10
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-scheduler-alpha/lib/group.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export interface IGroup extends IResource {
*
* @default - sum over 5 minutes
*/
metricSentToDLQTrunacted(props?: cloudwatch.MetricOptions): cloudwatch.Metric;
metricSentToDLQTruncated(props?: cloudwatch.MetricOptions): cloudwatch.Metric;

/**
* Grant the indicated permissions on this group to the given principal
Expand Down Expand Up @@ -224,7 +224,7 @@ abstract class GroupBase extends Resource implements IGroup {
*
* @default - sum over 5 minutes
*/
public metricSentToDLQTrunacted(props?: cloudwatch.MetricOptions): cloudwatch.Metric {
public metricSentToDLQTruncated(props?: cloudwatch.MetricOptions): cloudwatch.Metric {
return this.metric('InvocationsSentToDeadLetterCount_Truncated_MessageSizeExceeded', props);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export class Schedule extends Resource implements ISchedule {
*
* @default - sum over 5 minutes
*/
public static metricAllSentToDLQTrunacted(props?: cloudwatch.MetricOptions): cloudwatch.Metric {
public static metricAllSentToDLQTruncated(props?: cloudwatch.MetricOptions): cloudwatch.Metric {
return this.metricAll('InvocationsSentToDeadLetterCount_Truncated_MessageSizeExceeded', props);
}

Expand Down

0 comments on commit 8b91e10

Please sign in to comment.