Fixed linting issue and missing jddoc comment

aws · Oct 5, 2024 · c8dcace · c8dcace
1 parent d798c01
commit c8dcace
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 3 deletions.
diff --git a/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/README.md b/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/README.md
@@ -334,8 +334,8 @@ api.addRoutes({
 
 // You can only access authorizerId after it's been bound to a route
 // In this example we expect use CfnOutput
-new CfnOutput(stack, 'authorizerId', authorizer.authorizerId);
-new CfnOutput(stack, 'authorizerType', authorizer.authorizerType);
+new CfnOutput(this, 'authorizerId', authorizer.authorizerId);
+new CfnOutput(this, 'authorizerType', authorizer.authorizerType);
 ```
 
 ```ts

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/lib/http/iam.ts b/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/lib/http/iam.ts
@@ -9,7 +9,7 @@ import {
  * Authorize HTTP API Routes with IAM
  */
 export class HttpIamAuthorizer implements IHttpRouteAuthorizer {
-    /**
+  /**
    * The authorizationType used for IAM Authorizer
    */
   public readonly authorizationType = HttpAuthorizerType.IAM;

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/test/http/jwt.test.ts b/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/test/http/jwt.test.ts
@@ -75,6 +75,7 @@ describe('HttpJwtAuthorizer', () => {
 
     // THEN
     expect(authorizer.authorizerId).toBeDefined();
+    expect(authorizer.authorizerId).toEqual(authorizer['authorizer']?.authorizerId);
   });
 
   test('should throw error when acessing authorizer before it been bound to route', () => {

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/test/http/lambda.test.ts b/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/test/http/lambda.test.ts
@@ -181,6 +181,7 @@ describe('HttpLambdaAuthorizer', () => {
 
     // THEN
     expect(authorizer.authorizerId).toBeDefined();
+    expect(authorizer.authorizerId).toEqual(authorizer['authorizer']?.authorizerId);
   });
 
   test('should throw error when acessing authorizer before it been bound to route', () => {

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/test/http/user-pool.test.ts b/packages/aws-cdk-lib/aws-apigatewayv2-authorizers/test/http/user-pool.test.ts
@@ -124,6 +124,7 @@ describe('HttpUserPoolAuthorizer', () => {
 
     // THEN
     expect(authorizer.authorizerId).toBeDefined();
+    expect(authorizer.authorizerId).toEqual(authorizer['authorizer']?.authorizerId);
   });
 
   test('should throw error when acessing authorizer before it been bound to route', () => {

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2/lib/http/authorizer.ts b/packages/aws-cdk-lib/aws-apigatewayv2/lib/http/authorizer.ts
@@ -257,6 +257,9 @@ function undefinedIfNoKeys<A extends { [key: string]: unknown }>(obj: A): A | un
  * Explicitly configure no authorizers on specific HTTP API routes.
  */
 export class HttpNoneAuthorizer implements IHttpRouteAuthorizer {
+  /**
+   * The authorizationType used for IAM Authorizer
+   */
   public readonly authorizationType = 'NONE';
   public bind(_options: HttpRouteAuthorizerBindOptions): HttpRouteAuthorizerConfig {
     return {
-Original file line number
+Diff line change
@@ Expand Up / @@ -75,6 +75,7 @@ describe('HttpJwtAuthorizer', () => { @@
         // THEN
         expect(authorizer.authorizerId).toBeDefined();
+        expect(authorizer.authorizerId).toEqual(authorizer['authorizer']?.authorizerId);
       });
       test('should throw error when acessing authorizer before it been bound to route', () => {
@@ Expand Down @@