Skip to content

Commit

Permalink
fix readme + delete old leftover
Browse files Browse the repository at this point in the history
  • Loading branch information
comcalvi committed Jun 29, 2023
1 parent 58b8d01 commit e39cbfd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-batch-alpha/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -502,9 +502,9 @@ The following example defines the `MY_SECRET_ENV_VAR` environment variable that
ARN of the Secret defined by `mySecret`:

```ts
import * as secretsmanager from 'aws-cdk-lib/aws-secretsmanager';
import * as cdk from 'aws-cdk-lib';

declare const mySecret: efs.ISecret;
declare const mySecret: secretsmanager.ISecret;

const jobDefn = new batch.EcsJobDefinition(this, 'JobDefn', {
container: new batch.EcsEc2ContainerDefinition(this, 'containerDefn', {
Expand Down
12 changes: 0 additions & 12 deletions packages/@aws-cdk/aws-batch-alpha/test/job-definition-base.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,16 +223,4 @@ describe.each([batch.EcsJobDefinition, batch.EksJobDefinition, batch.MultiNodeJo
},
});
});

/*
test('can be imported from name', () => {
// WHEN
const importedJob = JobDefinition.fromJobDefinitionName(stack, 'job-def-clone', 'job-def-name');
// THEN
expect(importedJob.jobDefinitionName).toEqual('job-def-name');
expect(importedJob.jobDefinitionArn)
.toEqual(`arn:${Aws.PARTITION}:batch:${Aws.REGION}:${Aws.ACCOUNT_ID}:job-definition/job-def-name`);
});
*/
});

0 comments on commit e39cbfd

Please sign in to comment.