fixed validation for maximumEventAgeInSeconds

aws · Oct 19, 2023 · ede8e75 · ede8e75
1 parent 51ab22e
commit ede8e75
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts b/packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts
@@ -257,8 +257,8 @@ export class Schedule extends Resource implements ISchedule {
   }
 
   private validateRetryPolicy(maximumEventAgeInSeconds: number | undefined, maximumRetryAttempts: number | undefined) {
-    if (maximumEventAgeInSeconds && (maximumEventAgeInSeconds < 60 || maximumEventAgeInSeconds > 900)) {
-      throw new Error(`maximumEventAgeInSeconds must be between 60 and 900, got ${maximumEventAgeInSeconds}`);
+    if (maximumEventAgeInSeconds && (maximumEventAgeInSeconds < 60 || maximumEventAgeInSeconds > 86400)) {
+      throw new Error(`maximumEventAgeInSeconds must be between 60 and 86400, got ${maximumEventAgeInSeconds}`);
     }
     if (maximumRetryAttempts && (maximumRetryAttempts < 0 || maximumRetryAttempts > 185)) {
       throw new Error(`maximumRetryAttempts must be between 0 and 185, got ${maximumRetryAttempts}`);

diff --git a/packages/@aws-cdk/aws-scheduler-alpha/test/retry-policy.test.ts b/packages/@aws-cdk/aws-scheduler-alpha/test/retry-policy.test.ts
@@ -91,7 +91,7 @@ describe('schedule target retry policy', () => {
         },
         enabled: false,
       });
-    }).toThrow(/maximumEventAgeInSeconds must be between 60 and 900, got 50/);
+    }).toThrow(/maximumEventAgeInSeconds must be between 60 and 86400, got 50/);
   });
 
   test('apply maximumEventAge max value validation', () => {
@@ -100,12 +100,12 @@ describe('schedule target retry policy', () => {
         schedule: expr,
         target: new SomeLambdaTarget(func),
         targetOverrides: {
-          maximumEventAge: Duration.seconds(1000),
+          maximumEventAge: Duration.seconds(100000),
           maximumRetryAttempts: 5,
         },
         enabled: false,
       });
-    }).toThrow(/maximumEventAgeInSeconds must be between 60 and 900, got 1000/);
+    }).toThrow(/maximumEventAgeInSeconds must be between 60 and 86400, got 100000/);
   });
 
   test('apply maximumRetryAttempts min value validation', () => {