Integrating AWS CodePipeline with the GitHub Commit Status API #24330
Replies: 18 comments 5 replies
-
Like I said before in our Gitter channel, this issue is about CodePipeline; the CodeBuild integration is automatic, described here: https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-codebuild/README.md#githubsource-and-githubenterprisesource |
Beta Was this translation helpful? Give feedback.
-
I'm sorry this isn't a PR but maybe you can use this. I'm using it in my pipeline and it works. Github Stage Status Construct: https://gist.github.com/jewelsjacobs/a0b627f3b9a176fbbb0d98f8ff7b1fea Github Status API Lambda: How the construct works in a pipeline stack(I'm using it on a build stage but it can be easily used in a multistage iteration type scenario): Screenshots: |
Beta Was this translation helpful? Give feedback.
-
@skinny85 I'm going to attempt to create a PR for this. Stay tuned .... |
Beta Was this translation helpful? Give feedback.
-
I'm sorry but I don't have off hours time to contribute this 😦 |
Beta Was this translation helpful? Give feedback.
-
@jewelsjacobs thanks so much for putting this together! just used the code you linked in your comment after stumbling through this myself for several hours and worked like a charm. any news on when this might get integrated directly into CDK? |
Beta Was this translation helpful? Give feedback.
-
@jewelsjacobs, would you mind if I use your code as a starting point for a PR to get this into aws-cdk? @skinny85 Is a lambda like this an acceptable addition? I'm unaware of any other instances in aws-cdk where a lambda is used to extend base functionality of a resource. If you think this would work and know of any other examples, I'd like to make sure we have consistency between additions of this type. |
Beta Was this translation helpful? Give feedback.
-
@corrjo go for it! I don't know if this is better. It's older and a package-able npm mod here: https://github.com/NewEraCodeRepo/nec-cdk-components |
Beta Was this translation helpful? Give feedback.
-
Absolutely 🙂. There are many places in the CDK where we use Lambda-backed CloudFormation custom resources to add some functionality not available otherwise: Good luck! |
Beta Was this translation helpful? Give feedback.
-
Reviewing old feature-requests, this still seems entirely valid. |
Beta Was this translation helpful? Give feedback.
-
I implemented a Github Status notifier as a custom construct but the Readme is still missing. If this is sth that might go into the core CDK I am happy to open a PR. |
Beta Was this translation helpful? Give feedback.
-
@hoegertn go for it, I was going to and had implemented it in our internal construct library but we ended up moving to circleci internally and I never had a chance to finish adding it here. |
Beta Was this translation helpful? Give feedback.
-
If somebody is still interested, I had it as a recurring need and created a CDK construct library for it: https://github.com/awesome-cdk/cdk-report-codepipeline-status-to-github If you think this is worth going into the CDK core, I would love to invest some time to port it. Somebody from the maintainers can confirm? |
Beta Was this translation helpful? Give feedback.
-
@Dzhuneyt we would welcome this - we are also looking for this functionality with CDK Pipelines when source from a GitHub repository. not sure if that is part of this issue though. |
Beta Was this translation helpful? Give feedback.
-
This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
Beta Was this translation helpful? Give feedback.
-
Still relevant in 2022. |
Beta Was this translation helpful? Give feedback.
-
I'd love to have a way to do this for the various waves in our pipelines. So, add a
|
Beta Was this translation helpful? Give feedback.
-
Hi all, as of now, we do not plan to implement this in the AWS CDK. If this feature is added to CodePipeline, then we would definitely consider adding CDK support. But as it is right now, we think it would be better for this feature to exist in a 3rd party library or in "user-land" CDK code. Rather than close the issue, I'm converting it to a discussion. There is valuable info here about workarounds and how to do it yourself, that we still want customers to be able to find. |
Beta Was this translation helpful? Give feedback.
-
Native integration works so cool for Azure and I can add some restrictions based on the pipeline result. When for CodePipilene I had to provide my personal access token and commit status provided from my name as a result. |
Beta Was this translation helpful? Give feedback.
-
I have a business requirement to display commit status' in our full github development workflow
This requires CodePipeline to be set up with the Github Status API https://github.blog/2012-09-04-commit-status-api/
Here is an example of implementing this with AWS CodePipeline, Amazon CloudWatch and AWS Lambda:
https://scratchpad.blog/2019/03/16/integrating-aws-codepipeline-with-the-github-commit-status-api.html
It would be even better to set this up through CDK!
Thanks :)
Beta Was this translation helpful? Give feedback.
All reactions