Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cloudwatch): Single Value Widget graph option: Number Widget Format #12066

Closed
cukierkowychleb opened this issue Dec 14, 2020 · 2 comments · Fixed by #12274
Closed

(cloudwatch): Single Value Widget graph option: Number Widget Format #12066

cukierkowychleb opened this issue Dec 14, 2020 · 2 comments · Fixed by #12274
Assignees
@rix0rrr
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@cukierkowychleb
Copy link

AWS Console supports option: Number Widget Format (Show as many digits as can fit, before rounding) however it is not possible to set singleValueFullPrecision property via cdk.

Use Case

CDK provides less configuration option than AWS Console so it not fully supports dashboard/graph creation programatically.

Proposed Solution

Add to

aws-cdk/packages/@aws-cdk/aws-cloudwatch/lib/graph.ts

Line 237 in 09e994a

export interface SingleValueWidgetProps extends MetricWidgetProps {

property singleValueFullPrecision as boolean.

This is a 🚀 Feature Request
@cukierkowychleb cukierkowychleb added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 14, 2020
@SomayaB SomayaB changed the title aws-cloudwatch: Single Value Widget graph option: Number Widget Format (cloudwatch): Single Value Widget graph option: Number Widget Format Dec 14, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Dec 14, 2020
@evmin
Copy link

evmin commented Dec 27, 2020

+1

yattoni added a commit to yattoni/aws-cdk that referenced this issue Dec 29, 2020
@yattoni
Closes aws#8940 and Closes aws#12066
07d95f2
yattoni added a commit to yattoni/aws-cdk that referenced this issue Dec 29, 2020
@yattoni
feat(cloudwatch): Add support for showing full precision with SingleV…
9924725 
…alueWidgets

Closes aws#8940 and Closes aws#12066
yattoni added a commit to yattoni/aws-cdk that referenced this issue Dec 29, 2020
@yattoni
feat(cloudwatch): support showing full precision with SingleValueWidgets
8cf4fcf 
Closes aws#8940 and Closes aws#12066
@yattoni yattoni mentioned this issue Dec 29, 2020
Merged
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2021
@mergify mergify bot closed this as completed in #12274 Jan 6, 2021
mergify bot pushed a commit that referenced this issue Jan 6, 2021
@yattoni
feat(cloudwatch): full precision for SingleValueWidgets (#12274)
45d78f0 
Closes #8940 and Closes #12066

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): full precision for SingleValueWidgets yattoni/aws-cdk
3 participants
@rix0rrr @evmin @cukierkowychleb