Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cloudfront): make distribution Security Policy configurable #12199

Closed
metametadata opened this issue Dec 22, 2020 · 1 comment · Fixed by #12231
Closed

(cloudfront): make distribution Security Policy configurable #12199

metametadata opened this issue Dec 22, 2020 · 1 comment · Fixed by #12231
Assignees
@njlynch
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@metametadata
Copy link

software.amazon.awscdk.services.cloudfront.Distribution should provide a way to set a custom Security Policy.

When editing a distribution in GUI it looks like this:

Screenshot 2020-12-22 at 17 11 45

Use Case

I need to ensure the specific version because my client apps expect the specific TLS version.

Proposed Solution

It was implemented for CloudFrontWebDistribution in #795 under viewerCertificate options. Maybe now it can become a property of Distribution 🤷

Other

CDK v. 1.78.0.

This is a 🚀 Feature Request
@metametadata metametadata added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 22, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Dec 22, 2020
@hassanazharkhan hassanazharkhan mentioned this issue Dec 26, 2020
Merged
@mergify mergify bot closed this as completed in #12231 Jan 4, 2021
mergify bot pushed a commit that referenced this issue Jan 4, 2021
@hassanazharkhan
feat(aws-cloudfront): support minimum security protocol (#12231)
40976d9 
Closes [#12199](#12199)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@hassanazharkhan @flochaz
feat(aws-cloudfront): support minimum security protocol (aws#12231)
a17eda5 
Closes [aws#12199](aws#12199)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-cloudfront): support minimum security protocol hassanazharkhan/aws-cdk
2 participants
@njlynch @metametadata