Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-cloudfront): support minimum security protocol #12231

Conversation

hassanazharkhan
Copy link
Contributor

@hassanazharkhan hassanazharkhan commented Dec 26, 2020

Closes #12199


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 26, 2020

@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Dec 26, 2020
@hassanazharkhan hassanazharkhan force-pushed the cloudfront/addedOptionToCustomizeSecurityProtocol branch from ac78c10 to 07a8584 Compare December 27, 2020 03:08
@hassanazharkhan
Copy link
Contributor Author

@skinny85 Can you please review this PR!

@skinny85
Copy link
Contributor

skinny85 commented Dec 30, 2020

@skinny85 Can you please review this PR!

Nope 🙂. @njlynch is the owner of the CloudFront module in our team, and I'd rather not merge a PR in his area without him present. He should be back from his holidays soon!

@hassanazharkhan hassanazharkhan changed the title feat(aws-cloudfront): Added option to customize minimum security prot… feat(aws-cloudfront): support minimum security protocol Jan 4, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ac3f0e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 40976d9 into aws:master Jan 4, 2021
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
Closes [aws#12199](aws#12199)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cloudfront): make distribution Security Policy configurable
4 participants